-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions assume you have speedtest-cli installed #20
Open
fermelone
wants to merge
20
commits into
fmdlc:master
Choose a base branch
from
fermelone:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Makefile to use the cURL Docker image to execute API initialization
Including telegraf Docker user into the video group to fetch GPU metrics
Enabling Kubernetes support
Beta v0.4
Realized after installing on a clean raspbian image that the instructions don't include the installation of speedtest-cli. A quick installation via pip, even on runtime, fixed it.
Hi @fermelone Thanks for submitting this PR. Speedtest-cli is installed in the Telegraf DockerImage. But if you want to run it from the bare metal it's ok to install it. |
fdelacruz-asapp
suggested changes
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add:
If you wish to run it in the baremetal, so you need to have
speedtest-cli
installed.
fmdlc
force-pushed
the
master
branch
4 times, most recently
from
October 24, 2020 21:30
0c8df66
to
9eaf212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized after installing on a clean raspbian image that the instructions don't include the installation of speedtest-cli.
A quick installation via pip, even on runtime, fixed it.