Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Boost include directories for ur_kinematics #17

Closed
stefanscherzinger opened this issue Aug 12, 2021 · 3 comments
Closed

Upgrade Boost include directories for ur_kinematics #17

stefanscherzinger opened this issue Aug 12, 2021 · 3 comments
Assignees

Comments

@stefanscherzinger
Copy link

Branch: calibration_devel
Use case: The issue came up here.

Problem statement:

The ur_kinematics package seems to use Boost includes via include_directories(SYSTEM ${Boost_INCLUDE_DIR}), which is a cache entry.

I'm not sure, though, why and how ur_kinematics would drop the own generation of such cache entries in that case, despite the package's

find_package(Boost REQUIRED COMPONENTS system)

Possible solution:
Use the result variable instead, as recommended here.

include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
@fmauch
Copy link
Owner

fmauch commented Aug 15, 2021

Let me come back to this later...

@fmauch fmauch self-assigned this Aug 15, 2021
@fmauch
Copy link
Owner

fmauch commented Jul 21, 2022

This issue should be migrated to the upstream repo. As ur_kinematics needs some attention, anyway this might be a relevant point to consider.

@fmauch
Copy link
Owner

fmauch commented Jul 21, 2022

Closing in favor of ros-industrial#603

@fmauch fmauch closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants