This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add supportTaskTypes for agentservice without write it in config twice. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
kumare3,
EngHabu and
hamersaw
as code owners
Merged
8 tasks
Future-Outlier
changed the title
Signed-off-by: Future Outlier <[email protected]>
…y-default-for-task-types Signed-off-by: Future-Outlier <[email protected]>
Codecov Report
Additional details and impacted files |
pingsutw
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title.
Note: Please merge the code below, so that the code will work!
flyteorg/flyteplugins#398
Type
Are all requirements met?
Complete description
Right now, the agent-service section doesn't need to add supportedTaskTypes anymore.
We can get it by "default-for-task-types" from tasks.
Tracking Issue
flyteorg/flyteplugins#398