Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

add support for gpu node selectors #390

Closed
wants to merge 15 commits into from
Closed

add support for gpu node selectors #390

wants to merge 15 commits into from

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Aug 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (552f145) 62.83% compared to head (a022beb) 64.33%.
Report is 11 commits behind head on master.

❗ Current head a022beb differs from pull request most recent head 5f98be2. Consider uploading reports for the commit 5f98be2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
+ Coverage   62.83%   64.33%   +1.49%     
==========================================
  Files         156      156              
  Lines       13116    10739    -2377     
==========================================
- Hits         8242     6909    -1333     
+ Misses       4253     3202    -1051     
- Partials      621      628       +7     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
go/tasks/plugins/k8s/kfoperators/mpi/mpi.go 74.49% <100.00%> (+3.14%) ⬆️
...o/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go 79.22% <100.00%> (+1.80%) ⬆️
...s/plugins/k8s/kfoperators/tensorflow/tensorflow.go 77.18% <100.00%> (+2.74%) ⬆️
go/tasks/plugins/k8s/ray/ray.go 77.56% <100.00%> (-0.71%) ⬇️
go/tasks/plugins/array/awsbatch/transformer.go 81.45% <60.00%> (+2.33%) ⬆️
go/tasks/pluginmachinery/flytek8s/pod_helper.go 72.97% <82.79%> (-1.14%) ⬇️

... and 130 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4127. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants