Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Debug default upload #2882

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Future-Outlier
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <[email protected]>
@Future-Outlier
Copy link
Member Author

put some logs

new context for FilePathTransformer

Remote Execution:  @@@ should_upload:  True
@@@ source_path:  /Users/future-outlier/code/dev/flytekit/build/local_example.txt
@@@ headers:  {}
@@@ remote_path:  None
@@@ should_upload:  False
Running Execution on Remote.
[2024-10-31T15:00:06.788+0800] {__init__.py:14} INFO - Pandas backend loaded 2.2.3
[2024-10-31T15:00:06.790+0800] {__init__.py:25} INFO - Numpy backend loaded 1.26.4
[2024-10-31T15:00:06.791+0800] {__init__.py:35} INFO - Pyspark backend loaded 3.5.2
[2024-10-31T15:00:06.791+0800] {__init__.py:43} INFO - Python backend loaded
Image localhost:30000/flytekit:qoVyL3nOf90RZOClkyJXBA found. Skip building.
@@@ should_upload:  True
@@@ source_path:  /Users/future-outlier/code/dev/flytekit/build/local_example.txt
@@@ headers:  {}
@@@ remote_path:  None

use the default context

@@@ source_path:  /Users/future-outlier/code/dev/flytekit/build/local_example.txt
@@@ headers:  {}
@@@ remote_path:  None
@@@ should_upload:  True
@@@ source_path:  /var/folders/3z/bsm4cddd4q18b_jc_2b2my4h0000gn/T/flyte-9gwfsnx_/raw/ffb0da4c60019751dfa8fa14bf2e7156/local_example.txt
@@@ headers:  {}
@@@ remote_path:  None
Running Execution on Remote.
[2024-10-31T15:06:16.912+0800] {__init__.py:14} INFO - Pandas backend loaded 2.2.3
[2024-10-31T15:06:16.915+0800] {__init__.py:25} INFO - Numpy backend loaded 1.26.4
[2024-10-31T15:06:16.917+0800] {__init__.py:35} INFO - Pyspark backend loaded 3.5.2
[2024-10-31T15:06:16.917+0800] {__init__.py:43} INFO - Python backend loaded
Image localhost:30000/flytekit:qoVyL3nOf90RZOClkyJXBA found. Skip building.
@@@ should_upload:  True
@@@ source_path:  /Users/future-outlier/code/dev/flytekit/build/local_example.txt
@@@ headers:  {}
@@@ remote_path:  None

@Future-Outlier
Copy link
Member Author

the context's file access's raw_output_fs and raw_output_prefix are wrong, not sure why

image

@Future-Outlier
Copy link
Member Author

I’ve decided to prioritize the gate-feature and stop here.

The main issue is that if we don’t create a new context at the top of the context stack, the original context will set file_access properties, like raw_output_fs and raw_output_prefix, to use local storage.

However, if we create a new context, then file_access will set raw_output_fs and raw_output_prefix to use remote storage instead.

The most confused things for me is I don't know why the default context use local storage.

@eapolinario
Copy link
Collaborator

Also, just want to confirm, this is pre-existing behavior, right? As in, it reproes in released versions of flytekit.

@Future-Outlier
Copy link
Member Author

Also, just want to confirm, this is pre-existing behavior, right? As in, it reproes in released versions of flytekit.

yes you are right, I will solve this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants