Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow Agent lazy module loading #2098

Closed

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Jan 11, 2024

Tracking issue

Fixes flyteorg/flyte#4401

Why are the changes needed?

This change is primarily to simplify the dependencies needed for things like generating API reference documentation for flytekit. Before one needed all dependencies of all plugins to render API docs.

What changes were proposed in this pull request?

How was this patch tested?

Use pytest.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2049

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.74%. Comparing base (eb20459) to head (9083e04).

Files Patch % Lines
.../flytekit-airflow/flytekitplugins/airflow/agent.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2098   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files         315      315           
  Lines       24142    24142           
  Branches     3666     3666           
=======================================
+ Hits        20458    20460    +2     
+ Misses       3025     3024    -1     
+ Partials      659      658    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier changed the title Airflow and Bigquery Agent lazy module loading Airflow Agent lazy module loading Jan 11, 2024
Future-Outlier and others added 4 commits February 6, 2024 08:18
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 1, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@pingsutw pingsutw closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Make flytekit plugins use lazy module loading
3 participants