Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernel selection option #1114

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

dpausp
Copy link
Member

@dpausp dpausp commented Sep 25, 2024

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

(internal)

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • no effect on regular operations, just to fix an error in NixOS tests
  • Security requirements tested? (EVIDENCE)
    • NixOS tests green on Hydra

Also works with missing ENC information now, which is a common
scenario in our NixOS tests.

PL-132972
@dpausp dpausp force-pushed the PL-132972-fix-kernel-selection-option branch from ca7b928 to b7dd679 Compare September 25, 2024 13:35
@dpausp dpausp marked this pull request as ready for review September 25, 2024 19:18
@dpausp dpausp merged commit 548fc8b into fc-24.05-dev Sep 25, 2024
2 checks passed
@dpausp dpausp deleted the PL-132972-fix-kernel-selection-option branch September 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants