Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 17.2.5 -> 17.2.7 #1107

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Sep 18, 2024

Pull in the gitlab update we did on our nixpkgs fork:

  • gitlab: 17.2.5 -> 17.2.7

PL-133033

@flyingcircusio/release-managers

Release process

Impact: gitlab will be restarted

Changelog:

  • gitlab: 17.2.5 -> 17.2.7

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • review fixed CVEs and their impact
    • must not introduce known regressions
    • has to work in our staging gitlab
  • Security requirements tested? (EVIDENCE)
    • automated NixOS tests still pass
    • updated our staging gitlab and worked through manual test checklist

Pull upstream NixOS changes, security fixes and package updates:

- gitlab: 17.2.5 -> 17.2.7
@osnyx osnyx marked this pull request as ready for review September 18, 2024 16:48
@dpausp dpausp merged commit 2f6cca8 into fc-24.05-dev Sep 19, 2024
2 checks passed
@dpausp dpausp deleted the PL-133033-gitlab-17.2.7-fc-nixos branch September 19, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants