Add basic role and integration for Grafana Loki #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces minimal, bare-bones platform integration for Grafana Loki, intended to serve as a basis for further development.
This includes:
json
filter.@flyingcircusio/release-managers
Release process
Impact: internal.
Changelog: none. This role is still under development, and is not yet intended for public use.
PR release workflow (internal)
Design notes
on
oroff
. Example: rate limiting.Security implications
This is a basic first implementation, we're reviewing and considering overall security measures in PL-133025.
At this point we're limiting retention to 30 days by default (overridable per loki instance). We are relying on the SRV firewall as usual and find unauthed/cleartext submission acceptable for now.
To reduce impact if attackers have access on a non-loki machine, we're limiting access to the loki API to selected endpoints.