Skip to content

Commit

Permalink
Use last non-EOL version for --python-platform macOS (astral-sh#3469)
Browse files Browse the repository at this point in the history
## Summary

I think, as a a rule, we can just use the last non-EOL version here for
x86 and ARM.

Closes astral-sh#3454.
  • Loading branch information
charliermarsh authored May 8, 2024
1 parent eec99f9 commit ca809ad
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 5 additions & 4 deletions crates/uv-configuration/src/target_triple.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ pub enum TargetTriple {
#[cfg_attr(feature = "schemars", schemars(rename = "x86_64-unknown-linux-gnu"))]
X8664UnknownLinuxGnu,

/// An ARM-based macOS target, as seen on Apple Silicon devices.
/// An ARM-based macOS target, as seen on Apple Silicon devices, with support for the
/// least-recent, non-EOL macOS version (12.0).
#[cfg_attr(feature = "clap", value(name = "aarch64-apple-darwin"))]
#[cfg_attr(feature = "schemars", schemars(rename = "aarch64-apple-darwin"))]
Aarch64AppleDarwin,

/// An x86 macOS target.
/// An x86 macOS target, with support for the least-recent, non-EOL macOS version (12.0).
#[cfg_attr(feature = "clap", value(name = "x86_64-apple-darwin"))]
#[cfg_attr(feature = "schemars", schemars(rename = "x86_64-apple-darwin"))]
X8664AppleDarwin,
Expand Down Expand Up @@ -96,8 +97,8 @@ impl TargetTriple {
),
Self::X8664AppleDarwin => Platform::new(
Os::Macos {
major: 10,
minor: 12,
major: 12,
minor: 0,
},
Arch::X86_64,
),
Expand Down
4 changes: 2 additions & 2 deletions uv.schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ca809ad

Please sign in to comment.