Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Avoid the "change" event if nothing changed #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid the "change" event if nothing changed #46

wants to merge 1 commit into from

Conversation

samuelsimoes
Copy link
Collaborator

Today if you call set, reset, clear methods and nothing change the change event is emitted anyway. This PR fix this.

@samuelsimoes samuelsimoes changed the title Avoid the "change" event em if nothing changed Avoid the "change" event if nothing changed Jul 10, 2016
@sobrinho
Copy link
Member

sobrinho commented Oct 3, 2016

:shipit:

sobrinho
sobrinho suggested changes Oct 3, 2016
View reviewed changes
Copy link
Member

@sobrinho sobrinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use subscribe instead of on to avoid the aggregated canceler algorithm.

@sobrinho sobrinho mentioned this pull request Oct 3, 2016
Closed
@sobrinho
Copy link
Member

sobrinho commented Oct 5, 2016

Rebase :)

@sobrinho sobrinho mentioned this pull request Nov 10, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sobrinho sobrinho sobrinho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelsimoes @sobrinho