FLUX DOCS: don't use legacy slack config in example #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Lowe <[email protected]>
Signed-off-by: Dave Lowe <[email protected]>
digitalbanana
changed the title
|
Thanks, can you squash your commits @digitalbanana I think I noticed this issue when I was setting up notifications last time (the legacy webhook is no longer an option to create, so you have to use the Bot token, but nothing else changes in these instructions), Thank you for making a PR to close it 🎉 |
|
It looks like you have noticed some things I didn't spot myself, actually Please squash and let me know when you are finished, then we can approve it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dave Lowe [email protected]
proposed change to use the recommended slack integration (not legacy)