-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement site redesign with dark mode #11172
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 916cd8a): https://flutter-docs-prod--pr11172-feat-site-redesign-9gpoto1c.web.app |
Interesting! You can now close the banner. I like it.
@parlough, this is, overall, looking and feeling fabulous. But I'll keep playing with it. |
Thanks for the feedback and issues! Keep them coming :)
Could you provide a screenshot or video of this? I'm not sure I understand as I haven't been able to reproduce it. If it's easier, free to message me it too. Thanks! |
In response to #11172 (comment)
I can't reproduce it today, either. So, nvm. |
I don't want to bog down this work, so please let me know if you'd like me to hold off on comments until its ready for review. I have some suggestions, and they all come down to personal preference. You should feel completely comfortable ignoring these if you disagree. Contrast: I feel there could be more contrast. (I like the colors otherwise.)
Spacing:
In general, I love the updates. It looks so much more modern and less corporate-y. Also, thank you for doing this work in which everyone has opinions, despite not having expertise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parlough, this looks and feels amazing. Thanks so much for all of your hard work. I'm going to approve this, but will let you land it when ready. Oh, and Kathy W approves of it, too. I showed it to her. :)
FWIW, automatic dark mode worked for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe consider adjusting the color scheme (subtract 15 degrees from the hue) so it's more aligned with the Flutter logo:
It'd be nice to have consistent hyperlink colors between the main content and when hovering on an "on this page" item. (I also think maybe the dark mode hyperlink color could "pop out" a bit more.)
Light mode | Dark mode | |
---|---|---|
main content | #004594 |
#ACC7FF |
"on this page" item | #0468D7 |
#0468D7 |
suggestion: | #0468D7 |
#58C0ff |
I'd personally prefer a shorter duration (and maybe a different curve?) for the search bar size change animation.
Overall thoughts: this looks phenomenal, simple yet modern vibes :)
I agree with this suggestion. (This is a nit, feel free to ignore.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks beautiful, very well done! Don't want to bog down this PR, so filed #11217 for ideas to improve left navigation
Rewrites the site styles from scratch, to improve accessibility and add support for dark mode, while also dropping the dependencies on bootstrap and jquery. Various smaller PRs have already landed over the past few months to facilitate this change. It was intentional to avoid large changes to the site layout and structure as part of this work.
Staged: https://flutter-docs-prod--pr11172-feat-site-redesign-9gpoto1c.web.app/
New features:
Issues resolved:
Resolves #3632
Resolves #8030
Resolves #7769
Resolves #1667
Fixes #1728
Fixes #1940
Fixes #2313
Fixes #8505
Fixes #9000
Fixes #9329
Fixes #10532
Fixes #10536
Fixes #10543
Contributes to #9495
Contributes to #10534
Contributes to #10535
Left for follow-up: