Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit default values in GeolocateControlOptions #1370

Conversation

sdabet-orpheo
Copy link

As a follow-up of #1260, set default values for timeout and maximumAge, with respect to https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition#syntax.

Copy link
Contributor

@aardrop aardrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the JsObjectWrapper always expect a timeout? Can this be a default value for it as well? If so if this is meant to be a default, it could be set as default to the PositionOptions class itself instead.

@sdabet-orpheo
Copy link
Author

Does the JsObjectWrapper always expect a timeout? Can this be a default value for it as well? If so if this is meant to be a default, it could be set as default to the PositionOptions class itself instead.

I have made a pull request on mapbox-gl-dart to set default values in PositionOptions, but the repository doesn't seem active anylonger.

@stale
Copy link

stale bot commented Oct 31, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 31, 2023
@stale stale bot closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants