-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: use never instead of dont_allow #4671
Conversation
86c93d6
to
7b97c00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
Please fix the following points.
Signed-off-by: Shizuo Fujita <[email protected]>
I'm checking if this failure on Windows has something to do with this change.
|
I have confirmed those Windows failures have nothing to do with this change. Currently, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Which issue(s) this PR fixes:
Fixes #4063
What this PR does / why we need it:
If it use the object applied
dont_allow
in the other test throughObjectSpace.each_object
, it will cause the error.To relax object constraints, this patch will use
never
instead.See sample code in #4063 (comment)
Docs Changes:
Release Note: