Update/Reload without downtime #4624
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daipom
changed the title
daipom
force-pushed
the
restart-without-downtime
branch
from
41fd042
to
d0f31e8
Compare
It launches Fluentd with Input plugins only. Here is the specification. * Those Input plugins emits the events to SourceOnlyBufferAgent. * The events is kept in the buf_file during the source-only-mode. * SIGRTMIN(34) cancels the mode. * After canceled, the new agent starts to load the buffer. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
restart-without-downtime
branch
from
d0f31e8
to
630f809
Compare
|
The basic implementation is done. |
Add a new feature: Update/Reload without downtime.
1. The supervisor receives SIGUSR2.
2. Spawn a new supervisor.
3. Take over shared sockets.
4. Launch new workers, and stop old processes in parallel.
* Launch new workers with source-only mode
* Limit to restart_without_downtime_ready? input plugin
* Send SIGTERM to the old supervisor after 10s delay from 3.
5. The old supervisor stops and sends SIGRTMIN(34) to the new one.
6. The new workers run fully.
Problem to solve:
Updating Fluentd or reloading a config causes downtime.
Plugins that receive data as a server, such as `in_udp`, `in_tcp`,
and `in_syslog`, cannot receive data during this time.
This means that the data sent by a client is lost during this
time unless the client has a re-sending feature.
This makes updating Fluentd or reloading a config difficult in
some cases.
Note: need these feature
* #4661
* treasure-data/serverengine#146
Co-authored-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
restart-without-downtime
branch
from
630f809
to
1cbbd9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
See #4622.
Specification:
Supported input plugins:
in_tcpin_udpin_syslogNeeds following:
Docs Changes:
TODO
Release Note:
TODO
TODO: