test: fix timecop version to keep clock specs in tests #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhys
requested changes
Jun 6, 2024
timecop 0.9.9 supports `Process.clock_gettime`. This breaks specifications of `process_extenstion` of Fluentd and `Fluent::Clock`. `Fluent::Clock` uses `CLOCK_MONOTONIC_RAW` if possible and it does not be affected. However, `CLOCK_MONOTONIC_RAW` is not available on Windows, so the impact on tests on Windows is very significant. For now, we should avoid this effect by fixing the version. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
test-fix-timecop-version-to-keep-clock-specs
branch
from
a5b97e8
to
57f821b
Compare
|
@kenhys Can I merge this? |
|
Let's rest of failures in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
Fix the current situation where CI is failing entirely.
timecop0.9.9 supportsProcess.clock_gettime.This breaks specifications of
process_extenstionof Fluentd andFluent::Clock.Process.clock_gettimesupport travisjeffery/timecop#419Fluent::ClockusesCLOCK_MONOTONIC_RAWif possible and it does not be affected.However,
CLOCK_MONOTONIC_RAWis not available on Windows, so the impact on tests on Windows is very significant.For now, we should avoid this effect by fixing the version.
Docs Changes:
Not needed.
Release Note:
Not needed.