Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use IO#popen instead of Kernel#open #4369

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Dec 27, 2023

Which issue(s) this PR fixes:

N/A

What this PR does / why we need it:

open("|command") spawns command and create pipes for processing pipeline.

This feature of Kernel#open is deprecated, replace it with IO#popen.

It fixes the following warning:

warning: Calling Kernel#open with a leading '|' is deprecated and will
be removed in Ruby 4.0; use IO.popen instead

Docs Changes:

N/A

Release Note:

N/A

open("|command") spawns command and create pipes for
processing pipeline.

This feature of Kernel#open is deprecated, replace it with
IO#popen.

It fixes the following warning:

  warning: Calling Kernel#open with a leading '|' is deprecated and will
  be removed in Ruby 4.0; use IO.popen instead

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys added this to the v1.17.0 milestone Dec 27, 2023
@ashie ashie self-requested a review January 10, 2024 02:29
Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashie ashie merged commit cbc10e3 into fluent:master Jan 10, 2024
12 of 16 checks passed
@kenhys kenhys deleted the use-io-popen branch March 14, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants