Fix graylog connecting issue #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, gelf-rb/issues/63 may be still brocker. |
|
For graylog, fluent-plugin-json-in-json-2 depends on yajl-ruby... |
|
Thanks. I see... |
|
TODO: eliminate yajl-ruby (yajl/json_gem) |
|
Purge yajl/json_gem explicitly from image? |
|
The issue of |
Closes: fluent#1479 Feedback from @mszyzdek ref. fluent#1479 (comment) * graylog flavour of fluentd-kubernetes-daemonset uses gelf 3.0.0 and this version of gelf gem has Fixnum in code, graylog-labs/gelf-rb@7cc3cbb * in ruby 3.2 Fixnum was removed after previous deprecation in version 2.4 https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/ * ruby in newest fluentd was upgraded to 3.2 fluent/fluentd-docker-image@4f1d5e8 so it also happened in fluentd-kubernetes-daemonset * gelf 3.0.0 cannot work with ruby 3.2+ so we can see sad error on container start NOTE: Even though gelf was updated to 3.1.0, still it has problem with reloading Fluentd configuration with SIGUSR2. This is known issue since Fluentd 1.8.0. ref. fluent/fluentd#2709 Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
approved these changes
Jul 12, 2024
|
Thanks, after #1507 was merged, let's ship it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1479
Feedback from @mszyzdek
ref. #1479 (comment)