Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin dependency opensearch-ruby to 3.0.1 #116

Merged
merged 2 commits into from
Oct 3, 2023
Merged

pin dependency opensearch-ruby to 3.0.1 #116

merged 2 commits into from
Oct 3, 2023

Conversation

24367dfa
Copy link
Contributor

@24367dfa 24367dfa commented Sep 20, 2023

Since opensearch-ruby recently adapted semantic versioning, we can pin the dependency to 3.0.1.
This Version includes a fix to opensearch-project/opensearch-ruby#205

This will solve #115 and possibly #98

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible

@24367dfa 24367dfa changed the title pin dependency opensearch-ruby t0 3.0.1 pin dependency opensearch-ruby to 3.0.1 Sep 20, 2023
@24367dfa
Copy link
Contributor Author

@cosmo0920 can i do anything else to move this PR forward?

@cosmo0920
Copy link
Collaborator

Almost all of tests are failed. We can't proceed this PR as-is. Would you mind if you tried to fix the failures? Or, do you need help for your fixes with @kenhys or @ashie?

@24367dfa
Copy link
Contributor Author

Almost all of tests are failed. We can't proceed this PR as-is. Would you mind if you tried to fix the failures? Or, do you need help for your fixes with @kenhys or @ashie?

i'll try my best fo fix this and will report back the day after tomorrow.

@24367dfa
Copy link
Contributor Author

Almost all of tests are failed. We can't proceed this PR as-is. Would you mind if you tried to fix the failures? Or, do you need help for your fixes with @kenhys or @ashie?

i'll try my best fo fix this and will report back the day after tomorrow.

I have difficulties to get the test setup running. I installed ruby 3.2.2 using rbenv and can locally reproduce the failing test run on ubuntu. (yay)

To get to a working state to start working off of, i tried running the tests for v1.1.4 (the last successful run of github actions) but i am seeing the same can't modify frozen String: "" errors as in the CI runs of this PR.

Am i holding it wrong?

Steps to reproduce:

curl -sL https://github.com/rbenv/rbenv-installer/raw/main/bin/rbenv-installer | bash -
rbenv install 3.2.2
rbenv global 3.2.2
git clone [email protected]:24367dfa/fluent-plugin-opensearch.git
cd fluent-plugin-opensearch
gem install bundler rake
bundle install
bundle exec rake test

@24367dfa
Copy link
Contributor Author

@cosmo0920 pinning webmock to 3.18.1 gets rid of the errors. could you approve another CI run?

fluent-plugin-opensearch.gemspec Outdated Show resolved Hide resolved
@24367dfa 24367dfa requested a review from cosmo0920 October 2, 2023 05:36
@cosmo0920
Copy link
Collaborator

@cosmo0920 pinning webmock to 3.18.1 gets rid of the errors. could you approve another CI run?

Could you follow DCO process again? DCO is failed now.

@24367dfa
Copy link
Contributor Author

24367dfa commented Oct 3, 2023

@cosmo0920 pinning webmock to 3.18.1 gets rid of the errors. could you approve another CI run?

Could you follow DCO process again? DCO is failed now.

/done :)

@cosmo0920 cosmo0920 merged commit b919c90 into fluent:main Oct 3, 2023
@cosmo0920
Copy link
Collaborator

Did you all have cycles to release this PR as v1.2.0, @kenhys @ashie?

@24367dfa 24367dfa mentioned this pull request Oct 11, 2023
1 task
kenhys added a commit that referenced this pull request Oct 2, 2024
Mainly improved retry logic and refresh aws credentials.

#116
#119
#131
#136
#142
#143
kenhys added a commit that referenced this pull request Oct 2, 2024
Mainly improved retry logic and refresh aws credentials.

#116
#119
#131
#136
#142
#143
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants