out_stackdriver bug fix: return cached token when current_timestamp is less than cached_expiration #9652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuaich
requested review from
braydonk,
igorpeshansky and
qingling128
as code owners
…han cached_expiration. Signed-off-by: shuaichen <[email protected]>
braydonk
reviewed
Nov 27, 2024
braydonk
reviewed
Nov 27, 2024
Signed-off-by: Braydon Kains <[email protected]>
braydonk
approved these changes
Nov 27, 2024
igorpeshansky
approved these changes
Nov 27, 2024
|
Guess we weren't the only ones to make this mistake! |
|
Since the |
|
Thank you Braydon! |
AdheipSingh
pushed a commit
to AdheipSingh/fluent-bit
that referenced
this pull request
Dec 4, 2024
…s less than cached_expiration (fluent#9652) * out_stackdriver: return cached token when current_timestamp is less than cached_expiration. Signed-off-by: shuaichen <[email protected]> * stackdriver: revert log line change Signed-off-by: Braydon Kains <[email protected]> --------- Signed-off-by: shuaichen <[email protected]> Signed-off-by: Braydon Kains <[email protected]> Co-authored-by: Braydon Kains <[email protected]> Signed-off-by: AdheipSingh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in out_stackdriver that expired cached tokens are returned.
No issue number.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.