-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_statsd: Implement metrics type of ingestion way #9119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-in_statsd-cmetrics
branch
from
July 23, 2024 06:18
84234cc
to
c362b3b
Compare
7 tasks
cosmo0920
force-pushed
the
cosmo0920-in_statsd-cmetrics
branch
from
July 26, 2024 10:17
c362b3b
to
6b88040
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-in_statsd-cmetrics
branch
from
August 14, 2024 08:19
6b88040
to
5b663fd
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-in_statsd-cmetrics
branch
from
August 14, 2024 08:52
5b663fd
to
f6fefa1
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
fujimotos,
edsiper,
leonardo-albertovich and
koleini
as code owners
August 14, 2024 08:59
note: I've cancelled Appveyor tests since they are taking too long, windows was validated by github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
$ bin/fluent-bit -i statsd -p metrics=On -o stdout -v
Sending Multiple Payloads from Another Terminal
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
TBD
Backporting
Additional Note
This PR needs to ingest multiple times per a cycle.
So, the metrics contexts of buffers sometimes concatenated and to be needed to loop to consume EOF.
This should be handled in #9118 and #9122.
This PR also depends on fluent/cmetrics#210.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.