-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: filter_wasm: Pass through msgpack format records into wasm filters #8431
Merged
edsiper
merged 5 commits into
master
from
cosmo0920-msgpack-packed-records-wasm-micro-runtime
Mar 14, 2024
Merged
wasm: filter_wasm: Pass through msgpack format records into wasm filters #8431
edsiper
merged 5 commits into
master
from
cosmo0920-msgpack-packed-records-wasm-micro-runtime
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-msgpack-packed-records-wasm-micro-runtime
branch
from
January 30, 2024 05:47
6242a25
to
bf49ab5
Compare
cosmo0920
force-pushed
the
cosmo0920-msgpack-packed-records-wasm-micro-runtime
branch
from
January 31, 2024 08:10
bf49ab5
to
243ed22
Compare
cosmo0920
force-pushed
the
cosmo0920-msgpack-packed-records-wasm-micro-runtime
branch
from
January 31, 2024 08:12
243ed22
to
afc3669
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-msgpack-packed-records-wasm-micro-runtime
branch
from
January 31, 2024 08:16
afc3669
to
2891854
Compare
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
January 31, 2024 09:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, wasm filter uses JSON encoding to pass records and its associated metadata.
There is a opportunity to improve the capability to handle msgpack format on Wasm ones because reducing encoding/decoding overheads.
This PR intends to pass through msgpack format of records into wasm filter mechanism.
When using msgpack format on wasm filter, it needn't encode from JSON to msgpack.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1293
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.