Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_azure_kusto : fix multiple files tail issue and timeout issue #8430

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

tanmaya-panda1
Copy link
Contributor

@tanmaya-panda1 tanmaya-panda1 commented Jan 28, 2024

  1. added kusto specific headers
  2. randomized kusto ingestion resources refresh interval
  3. made kusto ingestion resources refresh interval configurable
  4. introduced gzip compression for payload
  5. added dynamic parsing of azure kusto ingestion resources
  6. fixed deadlock and added granular locks
  7. added default kusto endpoints connection timeout interval configs

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change

[OUTPUT]
name azure_kusto
match *
tenant_id xxxxxxx
client_id xxxxxxx
client_secret xxxxxx
ingestion_endpoint https://ingest-xxxxxx.kusto.windows.net
database_name xxxxx
table_name FluentBit
ingestion_endpoint_connect_timeout 600
compression_enabled On
ingestion_resources_refresh_interval 7200

  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

https://github.com/fluent/fluent-bit-docs/pull/1405/files

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@tanmaya-panda1 tanmaya-panda1 changed the title Fix/timeout issue [out_azure_kusto] fix multiple files tail issue and timeout issue Jan 28, 2024
Signed-off-by: Tanmaya Panda <[email protected]>
@Ripurwar80
Copy link

Hi tanmaya, facing an issue with regards to multiple tail inputs, Hope you can help me:
#8419

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@tanmaya-panda1
Copy link
Contributor Author

Added documentation for the above changes

https://github.com/fluent/fluent-bit-docs/pull/1405/files

tanmaya-panda1 and others added 2 commits July 5, 2024 07:38
…azure kusto http headers

out_azure_kusto : removed extra comma
out_azure_kusto : made refresh interval configurable
out_azure_kusto : randomized refresh interval
out_azure_kusto : azure kusto ingestion resources dynamic parsing
out_azure_kusto : added kusto http header and randomizing ingestion resources loading
out_azure_kusto : added additional mutexes

Signed-off-by: Tanmaya Panda <[email protected]>
@kpantos
Copy link

kpantos commented Oct 21, 2024

@edsiper Given that the requested changes have been implemented, is there an ETA on when this pull request will be merged into the main branch?
Customers want to use this in their production clusters and are asking when this will be generally available.

@tanmaya-panda1
Copy link
Contributor Author

@kpantos Since the PR is not yet merged, we have built custom Docker images from this branch that the customers can use in their environment
ARM image : [https://hub.docker.com/layers/agramachandran/fluent-bit/fix-ARM/images/sha256-f3b9575ab878d7a370364461a3c9c0b4ec250e204a16175863508ce121c9ecba?context=explore]
AMD image : [https://hub.docker.com/layers/agramachandran/fluent-bit/fix-AMD/images/sha256-3a2fe380a48d93a8d53142fd9ce3c26414f4acb48a29a435954557019d64104c?context=explore]

@kpantos
Copy link

kpantos commented Oct 24, 2024

Thank you @tanmaya-panda1 customer is already using these images.
Having said that they want to make sure this implementation is actually hitting the main branch of the official repository and that this plugin is supported as part of the official product and not a forked individual contribution.

From what I was able to see in this thread most of the reviewed items have been remediated already and there aren't any pending open issues. So, do you have any idea on when this pull request is going to be merged into the main branch?

@lecaros
Copy link
Contributor

lecaros commented Nov 1, 2024

hello @tanmaya-panda1 and @kpantos,
This PR is in the queue for the next 3.2 release.

@kpantos
Copy link

kpantos commented Nov 1, 2024

Thanks @lecaros, really appreciate the response

@seizste
Copy link

seizste commented Nov 25, 2024

Hello @lecaros @kpantos am i right that this was not merged as part of v3.2.0 ? Any idea when this will be the case and whatˋs missing to do so ?

@tanmaya-panda1
Copy link
Contributor Author

@edsiper @lecaros @leonardo-albertovich Can you guys please help us understand what is stopping the PR. It will give greater clarity to all the stakeholders waiting for this PR to merge.

@edsiper edsiper merged commit 557b0b5 into fluent:master Nov 26, 2024
84 checks passed
AdheipSingh pushed a commit to AdheipSingh/fluent-bit that referenced this pull request Dec 4, 2024
…uent#8430)

- added kusto specific headers
- randomized kusto ingestion resources refresh interval
- made kusto ingestion resources refresh interval configurable
- introduced gzip compression for payload
 -added dynamic parsing of azure kusto ingestion resources
- fixed deadlock and added granular locks
- added default kusto endpoints connection timeout interval configs

---------

Signed-off-by: Tanmaya Panda <[email protected]>
Co-authored-by: root <root@fluentbitvm.m2d2gsu3tjfejnx4nkwynra25e.bx.internal.cloudapp.net>
Co-authored-by: Ramachandran A G <[email protected]>
Signed-off-by: AdheipSingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants