in_calyptia_fleet: improve configuration reloading. #7925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a reload is required. Signed-off-by: Phillip Whelan <[email protected]>
…lector sooner. Signed-off-by: Phillip Whelan <[email protected]>
…lename to properly account for the timestamp. Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
pwhelan
changed the title
edsiper
requested changes
Sep 15, 2023
Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
7 tasks
leonardo-albertovich
pushed a commit
that referenced
this pull request
Oct 5, 2023
- use current configuration timestamp to evaluate if a reload is required. - increase minimum interval to 15 seconds, pause collector sooner. - use symlinks instead of hardlinks and check the filename to properly account for the timestamp. - in_calyptia_fleet: initialize ctx->collect_fd to -1. - in_calyptia_fleet: check return value from strtol() --------- Signed-off-by: Phillip Whelan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR correctly detects when the fleet configuration changes in the calyptia API as well as handling reloading more effectively.
Description
The actual timestamp from the configuration file name is now used to compare to the 'Last-Modified' date of the fleet configuration to determine a new configuration requires loading.
Care is also now taken to avoid two reloads to occur at the same time:
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.