Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml/v2: suppress debug messages. #7857

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Aug 23, 2023

Summary

During development to debug the parser many messages were left as error messages. This is due to the fact that the log level is not actually configured in flb_main until after parsing configuration files. I will open a PR with a possible fix for that later. For now the messages will be demoted to debugging for now.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan temporarily deployed to pr August 23, 2023 14:51 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 23, 2023 14:51 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 23, 2023 14:51 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 23, 2023 15:17 — with GitHub Actions Inactive
@edsiper
Copy link
Member

edsiper commented Aug 29, 2023

@pwhelan please fix the commit prefix, it should be config_format: yaml: ...

@edsiper edsiper added this to the Fluent Bit v2.1.9 milestone Aug 29, 2023
@pwhelan pwhelan force-pushed the pwhelan-yaml-supress-debug branch from 5035137 to 89187ae Compare August 29, 2023 15:19
@pwhelan
Copy link
Contributor Author

pwhelan commented Aug 29, 2023

@pwhelan please fix the commit prefix, it should be config_format: yaml: ...

Done, as requested.

@pwhelan pwhelan temporarily deployed to pr August 29, 2023 15:20 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 29, 2023 15:20 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 29, 2023 15:20 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 29, 2023 15:53 — with GitHub Actions Inactive
@edsiper edsiper merged commit 1a68244 into master Aug 29, 2023
36 of 37 checks passed
@edsiper edsiper deleted the pwhelan-yaml-supress-debug branch August 29, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants