Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calyptia: submit metrics when not in fleet mode. #7833

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Aug 16, 2023

Summary

Submit metrics to calyptia cloud when not in fleet mode.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.


@pwhelan pwhelan requested review from edsiper and niedbalski August 16, 2023 20:55
@pwhelan pwhelan self-assigned this Aug 16, 2023
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 20:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 20:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 20:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 21:16 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 21:16 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 21:16 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 16, 2023 21:46 — with GitHub Actions Inactive
Copy link
Member

@edsiper edsiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the code to the style as described here:

https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#braces-usage-on-conditionals-loops-and-functions

Also, please change the commit subject so it represents the component that is being changed, in this case is custom_calyptia:

https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes

plugins/custom_calyptia/calyptia.c Outdated Show resolved Hide resolved
@pwhelan pwhelan force-pushed the pwhelan-calyptia-fix-metrics branch from 7d12591 to 0f68635 Compare August 21, 2023 15:18
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:19 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:19 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:19 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:53 — with GitHub Actions Inactive
@pwhelan pwhelan requested a review from edsiper August 21, 2023 15:57
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:57 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:57 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 15:57 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 16:28 — with GitHub Actions Inactive
@pwhelan pwhelan force-pushed the pwhelan-calyptia-fix-metrics branch from 9a09c0e to b866082 Compare August 21, 2023 17:48
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 17:49 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 17:49 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 17:49 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr August 21, 2023 18:15 — with GitHub Actions Inactive
@edsiper edsiper merged commit 030e6ab into master Aug 29, 2023
@edsiper edsiper deleted the pwhelan-calyptia-fix-metrics branch August 29, 2023 10:30
@edsiper edsiper added this to the Fluent Bit v2.1.9 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants