Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_exec_wasi: fix possible file descriptor leak #7810

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

DavidKorczynski
Copy link
Contributor


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@DavidKorczynski DavidKorczynski temporarily deployed to pr August 8, 2023 18:36 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr August 8, 2023 18:36 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr August 8, 2023 18:36 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr August 8, 2023 19:06 — with GitHub Actions Inactive
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's reasonable. Thanks for the fix.

@edsiper edsiper added this to the Fluent Bit v2.1.9 milestone Aug 29, 2023
@edsiper edsiper merged commit 45457d4 into fluent:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants