[docs][sc-105732] Update the Fluent Bit monitoring page #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmerel
approved these changes
Sep 6, 2024
administration/monitoring.md
Outdated
Comment on lines
10
to
12
| Fluent Bit includes features for monitoring the internals of your pipeline, and for | ||
| connecting to Prometheus and Grafana, Health checks, and connectors to use external | ||
| services: |
There was a problem hiding this comment.
Suggested change
| Fluent Bit includes features for monitoring the internals of your pipeline, and for | |
| connecting to Prometheus and Grafana, Health checks, and connectors to use external | |
| services: | |
| Fluent Bit includes features for monitoring the internals of your pipeline, | |
| connecting to Prometheus and Grafana, Health checks, and connectors to use external | |
| services: |
multiple ands in there feels awkward
There was a problem hiding this comment.
Mmm, yeah -- good callout! I'll change to read:
Fluent Bit includes features for monitoring the internals of your pipeline, in
addition to connecting to Prometheus and Grafana, Health checks, and connectors to
use external services:
| | /api/v2/reload | Execute hot reloading or get the status of hot reloading. See the [hot-reloading documentation](hot-reload.md). | JSON | | ||
|
|
||
| ### v1 metrics | ||
|
|
There was a problem hiding this comment.
should be an sentence here between headers but it's not a blocker, same for below, but that can totally be iterated later.
There was a problem hiding this comment.
ACK -- will add a sentence there 👍
lockewritesdocs
deleted the
adamlocke/sc-105732/update-administration-monitoring-md-fluent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Fluent Bit monitoring page for style and consistency with Chronosphere guidelines.