es_out: support Upstream Servers with configuration overriding #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mabrarov
force-pushed
the
feature/out_es_upstream_support_extended
branch
from
cb36f75
to
7611f0e
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This pull request is waiting for review of fluent/fluent-bit#7608 |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
mabrarov
force-pushed
the
feature/out_es_upstream_support_extended
branch
from
7611f0e
to
25c7642
Compare
mabrarov
force-pushed
the
feature/out_es_upstream_support_extended
branch
from
25c7642
to
7138a28
Compare
mabrarov
force-pushed
the
feature/out_es_upstream_support_extended
branch
from
7138a28
to
c1092dc
Compare
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
reviewed
Aug 29, 2024
cnorris-cs
approved these changes
Aug 29, 2024
Signed-off-by: Marat Abrarov <[email protected]>
…ed / missing. Signed-off-by: Marat Abrarov <[email protected]>
…h backticks. Signed-off-by: Marat Abrarov <[email protected]>
mabrarov
force-pushed
the
feature/out_es_upstream_support_extended
branch
from
c1092dc
to
a78ebf2
Compare
… with backticks, fixed punctuation and reworded "Description" column. Signed-off-by: Marat Abrarov <[email protected]>
mabrarov
force-pushed
the
feature/out_es_upstream_support_extended
branch
from
a78ebf2
to
c620db5
Compare
|
Hi @cnorris-cs, I applied some (!) parts of your suggestions as well as introduced additional changes for consistency with your suggestions. Please take a look at this pull request one more time when you have time. Some of the changes are implemented in dedicated commits (for ease of revert in case of concerns) - please let me know if I need to squash all commits into a single one. Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Upstream feature for the Elasticsearch output plugin.
Refer to fluent/fluent-bit#7608 for the changes in Fluent Bit code.