Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feature: Refactored the build table interactor
- Loading branch information
1 parent
5e4757d
commit 0f373bb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,21 @@ | ||
| const { entries } = require('../../../../tests/mocks'); | ||
| const calculateBests = require('../calculateBests'); | ||
|
|
||
| describe('Interactors | .buildTable | .calculateBests', () => { | ||
| it('returns the best stats for DESC sort order', () => { | ||
| const response = calculateBests(entries); | ||
| expect(response).toMatchObject({ | ||
| totalReviews: 4, | ||
| totalComments: 5, | ||
| commentsPerReview: 5, | ||
| openedPullRequests: 30, | ||
| }); | ||
| }); | ||
|
|
||
| it('returns the best stats for ASC sort order', () => { | ||
| const response = calculateBests(entries); | ||
| expect(response).toMatchObject({ | ||
| timeToReview: 1_000_000, | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,127 +1,139 @@ | ||
| const { t } = require('../../../i18n'); | ||
| const { entries } = require('../../../../tests/mocks'); | ||
| const { STATS, VALID_STATS } = require('../../../config/stats'); | ||
|
Check failure on line 3 in src/interactors/buildTable/__tests__/getTableData.test.js
|
||
| const getTableData = require('../getTableData'); | ||
|
|
||
| const bests = { | ||
| totalReviews: 4, | ||
| totalComments: 5, | ||
| commentsPerReview: 5, | ||
| openedPullRequests: 30, | ||
| timeToReview: 1_000_000, | ||
| }; | ||
|
|
||
| describe('Interactors | .buildTable | .getTableData', () => { | ||
| const defaultParams = { | ||
| bests, | ||
| entries, | ||
| mainStats: VALID_STATS, | ||
| disableLinks: true, | ||
| displayCharts: false, | ||
| }; | ||
|
|
||
| it('builds the headers successfully', () => { | ||
| const response = getTableData(defaultParams); | ||
| expect(response.headers[0]).toEqual({ text: t('table.columns.username') }); | ||
| VALID_STATS.forEach((statName, index) => { | ||
| expect(response.headers[index + 1]).toEqual({ text: t(`table.columns.${statName}`) }); | ||
| }); | ||
| }); | ||
|
|
||
| it('builds the users correctly', () => { | ||
| const response = getTableData(defaultParams); | ||
| response.rows.forEach((row, index) => { | ||
| expect(row.user).toEqual({ | ||
| link: entries[index].user.url, | ||
| image: entries[index].user.avatarUrl, | ||
| text: entries[index].user.login, | ||
| emoji: null, | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('builds the stats successfully', () => { | ||
| const response = getTableData(defaultParams); | ||
| response.rows.forEach((row) => { | ||
| row.stats.forEach((stat) => { | ||
| expect(stat).toEqual({ | ||
| text: expect.any(String), | ||
| bold: expect.any(Boolean), | ||
| link: null, | ||
| chartValue: null, | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('displays only the requested stats', () => { | ||
| const testCases = [ | ||
| VALID_STATS, | ||
| [VALID_STATS[0]], | ||
| [VALID_STATS[VALID_STATS.length - 1], VALID_STATS[0]], | ||
| ]; | ||
|
|
||
| testCases.forEach((mainStats) => { | ||
| const response = getTableData({ ...defaultParams, mainStats }); | ||
| expect(response.headers.length).toEqual(mainStats.length + 1); | ||
| response.rows.forEach((row) => { | ||
| expect(row.stats.length).toEqual(mainStats.length); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('adds the stats link when required', () => { | ||
| const response = getTableData({ | ||
| ...defaultParams, | ||
| disableLinks: false, | ||
| }); | ||
|
|
||
| response.rows.forEach((row, index) => { | ||
| VALID_STATS.forEach((statName, statIndex) => { | ||
| const link = entries[index].urls[statName] || null; | ||
| expect(row.stats[statIndex].link).toEqual(link); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('adds the bold option to the best stats', () => { | ||
| const mainStats = [STATS.totalReviews.id]; | ||
| const response = getTableData({ | ||
| ...defaultParams, | ||
| mainStats, | ||
| }); | ||
|
|
||
| expect(response.rows[0].stats[0].bold).toEqual(true); | ||
| expect(response.rows[1].stats[0].bold).toEqual(false); | ||
| expect(response.rows[2].stats[0].bold).toEqual(false); | ||
| }); | ||
|
|
||
| it('adds the chart value when required', () => { | ||
| const mainStats = [STATS.totalReviews.id]; | ||
| const response = getTableData({ | ||
| ...defaultParams, | ||
| mainStats, | ||
| displayCharts: true, | ||
| }); | ||
|
|
||
| response.rows.forEach((row, index) => { | ||
| mainStats.forEach((statName, statIndex) => { | ||
| const chartValue = entries[index].contributions[statName]; | ||
| expect(row.stats[statIndex].chartValue).toEqual(chartValue); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('adds the emoji when required', () => { | ||
| const displayCharts = true; | ||
| const response = getTableData({ | ||
| ...defaultParams, | ||
| displayCharts, | ||
| }); | ||
|
|
||
| expect(response.rows[0].user.emoji).toEqual('medal1'); | ||
| expect(response.rows[1].user.emoji).toEqual('medal2'); | ||
| expect(response.rows[2].user.emoji).toEqual('medal3'); | ||
| }); | ||
|
|
||
| it('parses the stat text correctly', () => { | ||
| const mainStats = [STATS.timeToReview.id]; | ||
| const response = getTableData({ | ||
| ...defaultParams, | ||
| mainStats, | ||
| }); | ||
| response.rows.forEach((row, index) => { | ||
| const value = entries[index].stats.timeToReview; | ||
| const text = STATS.timeToReview.parser(value); | ||
| expect(row.stats[0].text).toEqual(text); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,50 @@ | ||
| const { entries } = require('../../../../tests/mocks'); | ||
| const { VALID_STATS } = require('../../../config/stats'); | ||
|
Check failure on line 2 in src/interactors/buildTable/__tests__/index.test.js
|
||
| const getTableData = require('../getTableData'); | ||
| const buildTable = require('../index'); | ||
|
|
||
| jest.mock('../getTableData', () => jest.fn()); | ||
|
|
||
| describe('Interactors | .buildTable', () => { | ||
| const defaultParams = { | ||
| entries, | ||
| limit: null, | ||
| sortKey: VALID_STATS[0], | ||
| mainStats: VALID_STATS, | ||
| disableLinks: true, | ||
| displayCharts: false, | ||
| }; | ||
|
|
||
| getTableData.mockImplementation(jest.requireActual('../getTableData')); | ||
|
|
||
| beforeEach(() => { | ||
| getTableData.mockClear(); | ||
| }); | ||
|
|
||
| it('limits the results', () => { | ||
| const response1 = buildTable(defaultParams); | ||
| expect(response1.rows.length).toEqual(entries.length); | ||
|
|
||
| const limit = 1; | ||
| const response2 = buildTable({ ...defaultParams, limit }); | ||
| expect(response2.rows.length).toEqual(limit); | ||
| }); | ||
|
|
||
| it('sorts data by the given key', () => { | ||
| const response = buildTable(defaultParams); | ||
| expect(response.rows[0].user.text).toEqual('user1'); | ||
| expect(response.rows[1].user.text).toEqual('user2'); | ||
| expect(response.rows[2].user.text).toEqual('user3'); | ||
| }); | ||
|
|
||
| it('calls build table data with the correct params', () => { | ||
| buildTable(defaultParams); | ||
| expect(getTableData).toHaveBeenCalledWith(expect.objectContaining({ | ||
| entries, | ||
| bests: expect.any(Object), | ||
| mainStats: defaultParams.mainStats, | ||
| disableLinks: defaultParams.disableLinks, | ||
| displayCharts: defaultParams.displayCharts, | ||
| })); | ||
| }); | ||
| }); | ||
Oops, something went wrong.