Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (nx-serverless): add an option to allow users to declare whether… #58

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

warrendugan
Copy link
Contributor

@warrendugan warrendugan commented Oct 22, 2020

Details: adds flag for CLI to allow user to tell builder whether to use tsconfig.base.json or tsconfig.json

Fixes/Feature #51 (it's a good idea to open an issue first for discussion)

  • yarn affected:test succeeds
  • yarn affected:e2e succeeds
  • yarn format:check succeeds
  • Code coverage does not decrease (if any source code was changed)
  • If applicable, appropriate Wiki docs were updated (if applicable)
  • If applicable, code review comments are written in the source code with / {Name}

@wickstargazer
Copy link
Member

Hi, i have disappeared for a while. with all the work going on. Lets review this and get it done?

the tests arn't passing should we check it out?

@wickstargazer wickstargazer merged commit 3b5e467 into flowaccount:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reference to tsconfig.json broken; renamed to tsconfig.base.json
2 participants