fix a signal creation bug

fix a bug where for the second process you start, signal processing would happen differently (e.g. scope would always be null)
flowable · Oct 4, 2024 · 92f1aab · 92f1aab
1 parent e8dda66
commit 92f1aab
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/...le-engine/src/main/java/org/flowable/engine/impl/dynamic/AbstractDynamicStateManager.java b/...le-engine/src/main/java/org/flowable/engine/impl/dynamic/AbstractDynamicStateManager.java
@@ -1549,9 +1549,6 @@ protected void processCreatedEventSubProcess(EventSubProcess eventSubProcess, Ex
  SignalEventDefinition signalEventDefinition = (SignalEventDefinition) eventDefinition;
  BpmnModel bpmnModel = ProcessDefinitionUtil.getBpmnModel(eventSubProcessExecution.getProcessDefinitionId());
  Signal signal = bpmnModel.getSignal(signalEventDefinition.getSignalRef());
- if (signal != null) {
- signalEventDefinition.setSignalRef(signal.getName());
- }
 
  ExecutionEntity signalExecution = processEngineConfiguration.getExecutionEntityManager().createChildExecution(eventSubProcessExecution.getParent());
  signalExecution.setCurrentFlowElement(startEvent);

diff --git a/...es/flowable-engine/src/main/java/org/flowable/engine/impl/util/ProcessInstanceHelper.java b/...es/flowable-engine/src/main/java/org/flowable/engine/impl/util/ProcessInstanceHelper.java
@@ -453,9 +453,6 @@ protected void handleSignalEventSubscription(EventDefinition eventDefinition, St
  SignalEventDefinition signalEventDefinition = (SignalEventDefinition) eventDefinition;
  BpmnModel bpmnModel = ProcessDefinitionUtil.getBpmnModel(parentExecution.getProcessDefinitionId());
  Signal signal = bpmnModel.getSignal(signalEventDefinition.getSignalRef());
- if (signal != null) {
- signalEventDefinition.setSignalRef(signal.getName());
- }
 
  ExecutionEntity signalExecution = processEngineConfiguration.getExecutionEntityManager().createChildExecution(parentExecution);
  signalExecution.setCurrentFlowElement(startEvent);