-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visuallizer for rllib fix, add more logging to tensorboard #879
base: master
Are you sure you want to change the base?
Conversation
@@ -329,4 +329,4 @@ def energy_consumption(env, gain=.001): | |||
|
|||
power += M * speed * accel + M * g * Cr * speed + 0.5 * rho * A * Ca * speed ** 3 | |||
|
|||
return -gain * power | |||
return -gain * power / len(env.k.vehicle.get_ids()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus comment
243979f
to
ccd5d01
Compare
ccd5d01
to
8fe8493
Compare
Fix visuallizer bug in rllib and add more logging to train.py