Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pylint from 3.2.7 to 3.3.1 #678

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Bump pylint from 3.2.7 to 3.3.1 #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcc9608
Bump pylint from 3.2.7 to 3.3.1
dependabot[bot] Oct 9, 2024
7e4f370
Update pylint too-many-arguments ignores to new versions name too-man…
flosell Oct 9, 2024
1569fbb
Turns out pylint has two rules for the same thing, disabling both
flosell Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bumpversion==0.6.0
pylint==3.2.7
pylint==3.3.1
pip==24.2
pytest==8.3.3
pytest-runner==6.0.1
Expand Down
2 changes: 1 addition & 1 deletion trailscraper/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def root_group(verbose):
help='Wait until events after the specified timeframe are found.')
@click.option('--parallelism', default=10, type=click.INT,
help='How many files to download in parallel')
# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
def download(bucket, prefix, org_id, account_id, region, log_dir, from_s, to_s, wait, parallelism):
"""Downloads CloudTrail Logs from S3."""
log_dir = os.path.expanduser(log_dir)
Expand Down
2 changes: 1 addition & 1 deletion trailscraper/cloudtrail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
class Record:
"""Represents a CloudTrail record"""

# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
def __init__(self, event_source, event_name,
resource_arns=None, assumed_role_arn=None, event_time=None, raw_source=None):
self.event_source = event_source
Expand Down
4 changes: 2 additions & 2 deletions trailscraper/s3_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def _s3_key_prefix_for_org_trails(prefix, date, org_id, account_id, region):
return f"{prefix}AWSLogs/{org_id}/{account_id}/CloudTrail/{region}/{date.year}/{date.month:02d}/{date.day:02d}/"


# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
def _s3_key_prefixes(prefix, org_ids, account_ids, regions, from_date, to_date):
delta = to_date.astimezone(pytz.utc) - from_date.astimezone(pytz.utc)

Expand Down Expand Up @@ -89,7 +89,7 @@ def _list_files_to_download(current_prefix):
consume(results) # Ensure we raise exceptions


# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
def download_cloudtrail_logs(target_dir, bucket, cloudtrail_prefix, org_ids,
account_ids, regions, from_date, to_date, parallelism):
"""Downloads cloudtrail logs matching the given arguments to the target dir"""
Expand Down