Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #156 #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Closes #156 #162

wants to merge 1 commit into from

Conversation

ocefpaf
Copy link

@ocefpaf ocefpaf commented Jun 1, 2021

Add a manifest file and fixed the setup.py to prevent faulty installation without dependencies and required files.

@ocefpaf
Copy link
Author

ocefpaf commented Jun 6, 2021

I need some help understand the test call here. I'm not familiar with go and my local tests with standard python the CLI call still works.

@flosell
Copy link
Owner

flosell commented Jun 12, 2021

The go script is just a bash script that orchestrates different things - in this case, what's failing is the test-setuptools script.
It's running python setup.py install and after that trailscraper guess in a clean docker container to see if everything installs correctly.
From what I can see, on your PR the console_scripts aren't generated or installed, therefore the installation actually doesn't install the trailscraper command into the PATH.
Comparing with a good build, I also done see any dependencies being installed... So something is off here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants