Turns out pylint has two rules for the same thing, disabling both

flosell · Oct 9, 2024 · 1569fbb · 1569fbb
1 parent 7e4f370
commit 1569fbb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/trailscraper/cli.py b/trailscraper/cli.py
@@ -50,7 +50,7 @@ def root_group(verbose):
               help='Wait until events after the specified timeframe are found.')
 @click.option('--parallelism', default=10, type=click.INT,
               help='How many files to download in parallel')
-# pylint: disable=too-many-positional-arguments
+# pylint: disable=too-many-positional-arguments,too-many-arguments
 def download(bucket, prefix, org_id, account_id, region, log_dir, from_s, to_s, wait, parallelism):
     """Downloads CloudTrail Logs from S3."""
     log_dir = os.path.expanduser(log_dir)

diff --git a/trailscraper/cloudtrail.py b/trailscraper/cloudtrail.py
@@ -21,7 +21,7 @@
 class Record:
     """Represents a CloudTrail record"""
 
-    # pylint: disable=too-many-positional-arguments
+    # pylint: disable=too-many-positional-arguments,too-many-arguments
     def __init__(self, event_source, event_name,
                  resource_arns=None, assumed_role_arn=None, event_time=None, raw_source=None):
         self.event_source = event_source

diff --git a/trailscraper/s3_download.py b/trailscraper/s3_download.py
@@ -18,7 +18,7 @@ def _s3_key_prefix_for_org_trails(prefix, date, org_id, account_id, region):
     return f"{prefix}AWSLogs/{org_id}/{account_id}/CloudTrail/{region}/{date.year}/{date.month:02d}/{date.day:02d}/"
 
 
-# pylint: disable=too-many-positional-arguments
+# pylint: disable=too-many-positional-arguments,too-many-arguments
 def _s3_key_prefixes(prefix, org_ids, account_ids, regions, from_date, to_date):
     delta = to_date.astimezone(pytz.utc) - from_date.astimezone(pytz.utc)
 
@@ -89,7 +89,7 @@ def _list_files_to_download(current_prefix):
         consume(results) # Ensure we raise exceptions
 
 
-# pylint: disable=too-many-positional-arguments
+# pylint: disable=too-many-positional-arguments,too-many-arguments
 def download_cloudtrail_logs(target_dir, bucket, cloudtrail_prefix, org_ids,
                              account_ids, regions, from_date, to_date, parallelism):
     """Downloads cloudtrail logs matching the given arguments to the target dir"""