feat(setup): modernize script execution #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotzbua
force-pushed
the
update_build_script
branch
from
b6683de
to
efa6370
Compare
florianfesti
force-pushed
the
update_build_script
branch
from
efa6370
to
744775b
Compare
|
Guess we should include running setup in the test suite at some point... |
Fixes inkex build
florianfesti
force-pushed
the
update_build_script
branch
from
744775b
to
dc370e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use subprocess for script execution. Solves bug with path splitting.
Reference
fixes #691