Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED Matrix #645

Merged
merged 2 commits into from
May 12, 2024
Merged

LED Matrix #645

merged 2 commits into from
May 12, 2024

Conversation

fidoriel
Copy link
Contributor

@fidoriel fidoriel commented Mar 9, 2024

This is a draft for a LED Matrix for those cheap Chinese ws2812b matrices.
Like on my other PR, I need to wait for a chance to cut it.

@florianfesti
Copy link
Owner

You may want to not indent the content of the description string. It is formatted with markdown and indentation is treated as pre-formatted text.

Don't worry about the CI failure. This is not your fault and I'll look into how to fix that independently of your PR.

@florianfesti
Copy link
Owner

Wrt you still not having a laser cutter: I really feel you. I have to leave my laser cutter behind when moving several years ago and was without one for quite a while. Live without a laser cutter is possible but ultimately pointless.

@fidoriel
Copy link
Contributor Author

I am new to the laser cutting game. Some things are more efficient, larger and look better if cutter. They promised they will have a cutter soon ;)

@fidoriel
Copy link
Contributor Author

fidoriel commented May 8, 2024

For some reason, not all images are shown

@fidoriel fidoriel marked this pull request as ready for review May 8, 2024 21:50
@fidoriel
Copy link
Contributor Author

fidoriel commented May 9, 2024

Everything is tested and fixes now. I am happy :)

@fidoriel
Copy link
Contributor Author

fidoriel commented May 9, 2024

@florianfesti did you find a solution to the typing error

Don't worry about the CI failure. This is not your fault and I'll look into how to fix that independently of your PR.

Did you find a solution or should I add a type ignore here?

florianfesti and others added 2 commits May 12, 2024 15:01
Not finding .fingerHolesAt()
WS2812b matrix enclosure for cheap chinease prebuild led matrixes.
This design assumes that the distance between the leds is equal in
both directions.
@florianfesti florianfesti merged commit e7257db into florianfesti:master May 12, 2024
2 checks passed
@florianfesti
Copy link
Owner

OK, fixed CI failure. Added the thumbnail to the checksums file and squashed all the commits.

Thanks for your work! Enjoy your new laser cutter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants