Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings for bed bolts #625

Closed

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Feb 10, 2024

This adds user configurable Settings for bed bolts. It's a bit odd because so far all previous pluggable Settings were for edges (and bed bolts are not really edges, but more like a tool that fingers can use), but it still works well.

To have an example, the closedbox (which already had bedbolts in the source but they were commented out) gains a configurable option to enable them.

There is one more change that'd make sense in my opinion, but it'll prefer to discuss that a bit first: I think that edge.Bolts should grow a second argument "layers", which defaults to 1 and is ignored on the drilling side. The total length is reduced by thickness * layers. This way, we can have the user configurable length parameter the length of the screw (plus tolerance), and depending on the number of sheets (with round holes) this will be screwed through, the length will be reduced accordingly. After all, as a user configuring this, I'll know the length of my screws, and I'll configure the thickness, but I'd use the same screws everywhere, and if there is in some place a constellation of two layers (which may happen in the box I'm doing this for), that should be accounted for by the box script.

@chrysn
Copy link
Contributor Author

chrysn commented Feb 11, 2024

I completely missed in my original check that there is also #468 that does something similar.

One item probably worth pulling from there is the drop-down list of standardized bolts. But I'll wait for an initial round of feedback at least on directions before proceeding here.

@florianfesti
Copy link
Owner

Closing this PR as it needs updating. We still have #36 open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants