Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoasterHolder generator #593

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Lavisx
Copy link

@Lavisx Lavisx commented Oct 15, 2023

This is my first work in this project. I hope that it is a correct style of code.

@florianfesti
Copy link
Owner

While this looks really nice it is very similar to the NotesHolder. I wonder if this could just be an style option for that. Not necessarily something you need to do yourself. What do you think?

@Lavisx
Copy link
Author

Lavisx commented Nov 29, 2023

@florianfesti Yes, it's similar, but unfortunately, it didn't suit me. In my design, the walls engages into the base, while in NotesHolder, the base engages with the walls. If there was a version in NotesHolder that addressed my needs and settings, I would certainly welcome it. However, I wouldn't dare attempt to combine both on my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants