[Connectors API] Add tests for ConnectorStateMachine (elastic#105736)

florent-leborgne · Feb 23, 2024 · ae4e57d · ae4e57d
1 parent 2ba37ff
commit ae4e57d
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/...ch/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorStateMachine.java b/...ch/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorStateMachine.java
@@ -42,6 +42,13 @@ public static boolean isValidTransition(ConnectorStatus current, ConnectorStatus
         return validNextStates(current).contains(next);
     }
 
+    /**
+     * Throws {@link ConnectorInvalidStatusTransitionException} if a
+     * transition from one {@link ConnectorStatus} to another is invalid.
+     *
+     * @param current The current {@link ConnectorStatus} of the {@link Connector}.
+     * @param next The proposed next {@link ConnectorStatus} of the {@link Connector}.
+     */
     public static void assertValidStateTransition(ConnectorStatus current, ConnectorStatus next)
         throws ConnectorInvalidStatusTransitionException {
         if (isValidTransition(current, next)) return;

diff --git a/...c/test/java/org/elasticsearch/xpack/application/connector/ConnectorStateMachineTests.java b/...c/test/java/org/elasticsearch/xpack/application/connector/ConnectorStateMachineTests.java
@@ -65,4 +65,31 @@ public void testTransitionToSameState() {
             assertFalse("Transition from " + state + " to itself should be invalid", ConnectorStateMachine.isValidTransition(state, state));
         }
     }
+
+    public void testAssertValidStateTransition_ExpectExceptionOnInvalidTransition() {
+        assertThrows(
+            ConnectorInvalidStatusTransitionException.class,
+            () -> ConnectorStateMachine.assertValidStateTransition(ConnectorStatus.CREATED, ConnectorStatus.CONFIGURED)
+        );
+    }
+
+    public void testAssertValidStateTransition_ExpectNoExceptionOnValidTransition() {
+        ConnectorStatus prevStatus = ConnectorStatus.CREATED;
+        ConnectorStatus nextStatus = ConnectorStatus.ERROR;
+
+        try {
+            ConnectorStateMachine.assertValidStateTransition(prevStatus, nextStatus);
+        } catch (ConnectorInvalidStatusTransitionException e) {
+            fail(
+                "Did not expect "
+                    + ConnectorInvalidStatusTransitionException.class.getSimpleName()
+                    + " to be thrown for valid state transition ["
+                    + prevStatus
+                    + "] -> "
+                    + "["
+                    + nextStatus
+                    + "]."
+            );
+        }
+    }
 }