Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added StringConverter::ToString for int and float #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgerhardy
Copy link
Contributor

No description provided.

@floooh
Copy link
Owner

floooh commented Mar 22, 2016

StringBuilder is a bit heavy for this, please use std::snprintf() into a char buffer on the stack (for instance, like here:

std::snprintf(buf, sizeof(buf), "{\"msg\":\"log\",\"val\":\"oryol assert: cond='%s'\nmsg='%s'\nfile='%s'\nline='%d'\nfunc='%s'\"}",
)

Also, you could be the first to add a few tests for this to

/// @todo IMPLEMENT STRING CONVERTER TEST!!!
;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants