[Infrared] Support tap emulate #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programistich
force-pushed
the
feature/single-tap-emulate
branch
from
6ce5cab to
22f615f
Compare
tonyfreeman
requested changes
Dec 2, 2024
| } else { | ||
| guard let flipper = device.flipper else { return } | ||
|
|
||
| if flipper.hasSingleEmulateSupport { |
There was a problem hiding this comment.
seems like it should be other way around
| @@ -2,5 +2,7 @@ import Core | |||
| import SwiftUI | |||
|
|
|||
| extension EnvironmentValues { | |||
| @Entry var emulateAction: (InfraredKeyID) -> Void = { _ in } | |||
| @Entry var emulateAction: ( | |||
| InfraredKeyID, Emulate.EmulateType | |||
There was a problem hiding this comment.
please separate arguments with a new line
| onTap() | ||
| } | ||
| .gesture( | ||
| LongPressGesture() |
| @@ -24,6 +24,11 @@ public class Emulate: ObservableObject { | |||
| case byIndex(Int) | |||
| } | |||
|
|
|||
| public enum EmulateType { | |||
| case infinite | |||
| case .infinite: | ||
| try await application.buttonPress(index: index) | ||
| case .single: | ||
| try await application.buttonPressRelease(index: index) |
There was a problem hiding this comment.
do we still need waitForMinimumDuration if we call press&release?
Programistich
force-pushed
the
feature/single-tap-emulate
branch
from
0443d5e to
8700c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.