a) Usage of val where it could be used. Retained type initialisation …

…for when it has to be latter passed down as an arg to a function.

b) .equalsIgnoreCase in selector tests has crept in during the previous sonar lints, corrected the same.
c) Addressed sonar lint issues on license block

ranger-core/src/test/java/com/flipkart/ranger/core/finder/nodeselector/RoundRobinServiceNodeSelectorTest.java

@@ -27,15 +27,15 @@ public class RoundRobinServiceNodeSelectorTest {
     @Test
     public void testRandomNodeSelector(){
         final RoundRobinServiceNodeSelector<TestNodeData> roundRobinSelector = new RoundRobinServiceNodeSelector<TestNodeData>();
-        List<ServiceNode<TestNodeData>> serviceNodes = Lists.newArrayList();
+        final List<ServiceNode<TestNodeData>> serviceNodes = Lists.newArrayList();
         serviceNodes.add(new ServiceNode<>("localhost-1", 9000, TestNodeData.builder().nodeId(1).build()));
         serviceNodes.add(new ServiceNode<>("localhost-2", 9001, TestNodeData.builder().nodeId(2).build()));
         serviceNodes.add(new ServiceNode<>("localhost-3", 9002, TestNodeData.builder().nodeId(3).build()));
         ServiceNode<TestNodeData> select = roundRobinSelector.select(serviceNodes);
-        Assert.assertTrue(select.getHost().equalsIgnoreCase("localhost-2"));
+        Assert.assertEquals("localhost-2", select.getHost());
         select = roundRobinSelector.select(serviceNodes);
-        Assert.assertTrue(select.getHost().equalsIgnoreCase("localhost-3"));
+        Assert.assertEquals("localhost-3", select.getHost());
         select = roundRobinSelector.select(serviceNodes);
-        Assert.assertTrue(select.getHost().equalsIgnoreCase("localhost-1"));
+        Assert.assertEquals("localhost-1", select.getHost());
     }
 }

ranger-core/src/test/java/com/flipkart/ranger/core/finder/shardselector/ListShardSelectorTest.java

@@ -30,7 +30,7 @@ public class ListShardSelectorTest {
 
     @Test
     public void testNoOpShardSelector(){
-        final ListBasedServiceRegistry serviceRegistry = RegistryTestUtils.getUnshardedRegistry();
+        final ListBasedServiceRegistry<TestNodeData> serviceRegistry = RegistryTestUtils.getUnshardedRegistry();
         final ListShardSelector<TestNodeData, Criteria<TestNodeData>> shardSelector = new ListShardSelector<>();
         final List<ServiceNode<TestNodeData>> nodes = shardSelector.nodes(CriteriaUtils.getCriteria(1), serviceRegistry);
         Assert.assertFalse(nodes.isEmpty());

ranger-http/src/main/java/com/flipkart/ranger/http/common/HttpNodeDataStoreConnector.java

@@ -48,7 +48,7 @@ public HttpNodeDataStoreConnector(
                 .connectionPool(new ConnectionPool(1, 30, TimeUnit.SECONDS))
                 .build();
         this.config = config;
-        this.mapper = null != mapper ? mapper : new ObjectMapper();
+        this.mapper = mapper;
     }
 
 

ranger-http/src/test/java/com/flipkart/ranger/http/common/HttpNodeDataStoreConnectorTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,6 +16,7 @@
 package com.flipkart.ranger.http.common;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.flipkart.ranger.core.units.TestNodeData;
 import com.flipkart.ranger.http.config.HttpClientConfig;
 import org.junit.Assert;
 import org.junit.Test;

ranger-http/src/test/java/com/flipkart/ranger/http/config/HttpClientConfigTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

ranger-http/src/test/java/com/flipkart/ranger/http/model/ServiceNodeResponseTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

ranger-http/src/test/java/com/flipkart/ranger/http/model/ServiceRegistrationResponseTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

ranger-http/src/test/java/com/flipkart/ranger/http/servicefinder/HttpShardedServiceFinderBuilderTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

ranger-http/src/test/java/com/flipkart/ranger/http/servicefinderhub/HttpServiceDataSourceTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

ranger-http/src/test/java/com/flipkart/ranger/http/serviceprovider/HttpShardedServiceProviderBuilderTest.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright 2015 Flipkart Internet Pvt. Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -51,8 +51,8 @@ public TestNodeData(@JsonProperty("farmId") String farmId) {
 
     @Test
     public void testProvider() throws Exception {
-        TestNodeData nm5NodeData = TestNodeData.builder().farmId("nm5").build();
-        ServiceNode<TestNodeData> testNode = new ServiceNode<>("localhost-1", 80, nm5NodeData);
+        val nm5NodeData = TestNodeData.builder().farmId("nm5").build();
+        val testNode = new ServiceNode<>("localhost-1", 80, nm5NodeData);
         val response = MAPPER.writeValueAsBytes(
                 ServiceRegistrationResponse.builder()
                         .success(true)
@@ -69,7 +69,7 @@ public void testProvider() throws Exception {
                 .connectionTimeoutMs(30_000)
                 .operationTimeoutMs(30_000)
                 .build();
-        ServiceProvider<TestNodeData, HttpRequestDataSerializer<TestNodeData>> serviceProvider = new HttpShardedServiceProviderBuilder<TestNodeData>()
+        val serviceProvider = new HttpShardedServiceProviderBuilder<TestNodeData>()
                 .withNamespace("testns")
                 .withServiceName("test")
                 .withHostname("localhost-1")