Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker builder #11

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

TheBiggerGuy
Copy link

Add a script to build the debs via Docker.

The aim of this is to enable a simple and clean way to build the debs without affecting the current system. This also has the byproduct to enabling CI (Travis) and building the ARM build on any platform via QEMU.

This is more of a "request of comments" than a polished pull request so please let me know if this is interesting for any further work. There is a working Travis build at https://travis-ci.org/TheBiggerGuy/piaware_builder

@mutability
Copy link
Contributor

Interesting. We're halfway through getting these packages onto stretch at the moment, FWIW. For the moment we're using pbuilder/cowbuilder (which will do qemu cross-arch builds too). docker-based builds may be useful further down the track.

This adds a "docker-build.sh" script that builds the full deb package using Docker. This allows any arch to build the native armhf package.
@TheBiggerGuy
Copy link
Author

OK I just rebased of the dev branch and enabled stretch builds to test them out.

Are you integrating pbuilder/cowbuilder into a CI? I find projects that have a public CI that push build artifacts very useful to connect commits/branches to the tar/debs. Also double checking commits and pull request can build is very useful.

If there is no immediate wish for this to be merged I will leave it as is.

I am planning on using this as a base for my work on on Docker-ising this for my https://github.com/TheBiggerGuy/docker-ads-b project.

@TheBiggerGuy TheBiggerGuy changed the base branch from master to dev July 9, 2018 18:19
@mutability
Copy link
Contributor

The end goal is probably to get it into a public CI, or at least to have the tools to plug it into a CI framework even if the actual CI itself isn't public. Not sure what the timeframe for that is, though.

@TheBiggerGuy
Copy link
Author

Would you like to keep this open or just close the pull request? Please feel free to close it.

This does have what I believe you are looking for. WIth a small change to the Travis config it can upload the debs to any place you wish, it produces reproducible builds from a clean slate and can be run from a CI, desktop or ARM device.

@mutability
Copy link
Contributor

Happy to keep it open - it might be a little while before I can get to merging it though

@mikenye
Copy link

mikenye commented Jul 12, 2018

Hi team,

It might interest you that I've done this as part of another project.

See: https://github.com/mikenye/docker-piaware

All you'd need to do is remove the steps after building the .deb file.

Builds happily on arm32v7 & amd64 - haven't tested on anything else.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants