Reduce default network flush time #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dump1090 network outputs don't offer timing guarantees or real-time timestamps, but it is still useful for aggregators to locally timestamp messages they receive from dump1090 on a best-effort basis. With lower message rates, 500 ms of flush interval can result in significant jitter for those timestamps. Most installs send data only on the local network or non-metered internet connections. If necessary this default can be adjusted via --net-ro-interval by users who require a longer flush interval for some reason. Reduce the default flush time to 90 ms to reliably flush every 2nd demodulation buffer when talking to an SDR (50 ms loop) and every loop iteration when running network-only (100 ms loop). fixes: flightaware#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dump1090 network outputs don't offer timing guarantees or real-time timestamps, but it is still useful for aggregators to locally timestamp messages they receive from dump1090 on a best-effort basis. With lower message rates, 500 ms of flush interval can result in significant jitter for those timestamps.
Most installs send data only on the local network or non-metered internet connections.
If necessary this default can be adjusted via --net-ro-interval by users who require a longer flush interval for some reason.
Reduce the default flush time to 90 ms to reliably flush every 2nd demodulation buffer when talking to an SDR (50 ms loop) and every loop iteration when running network-only (100 ms loop).
fixes: #244