Avoid GLOB_RECURSE in CMakeLists #561
Open
+456
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- glog with CONFIGURE_DEPENDS is not recommended since proper support is not guaranteed for all generators - performance can be really awful depending on OS (Windows for example) or hardware - all globs are evaluated again for each rebuild of any target
SpaceIm
force-pushed
the
cmake-avoid-glob-recurse
branch
from
427afb1
to
66dd438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really had a hard-time on Windows while rebuilding specific targets to fix issues in #461, even with Ninja and a good SSD. I mean, waiting 15s each time is not very convenient.
Here are some reason to not use glob:
This change is