-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SP-ization #1562
base: master
Are you sure you want to change the base?
SP-ization #1562
Conversation
…m SerialParallelDecomposition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 78 files reviewed, 1 unresolved discussion (waiting on @lockshaw)
lib/utils/test/src/utils/graph/series_parallel/sp_ization/spanish_algo.cc
line 23 at r1 (raw file):
TEST_SUITE(FF_TEST_SUITE) { TEST_CASE("spanish_algo - subcomponents") { SUBCASE("add_dummy_nodes") {
how should I test graphs where nodes are added? Here I check for some properties but it's obviously non-exhaustive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 78 files reviewed, 3 unresolved discussions (waiting on @lockshaw)
lib/utils/include/utils/graph/series_parallel/sp_ization/work_preserving_sp_ization.h
line 64 at r1 (raw file):
*the SP-ized graph. **/ SeriesParallelDecomposition cost_aware_stratum_sync_sp_ization(
old cost-aware algo, will leave it in for benchmarking purposes though we'll probably remove it eventually
bin/sp_ization_benchmarking/nasnet_bench_graph_generator.h
line 1 at r1 (raw file):
// For context, see https://arxiv.org/abs/1902.09635 &&
Benchmarking code is a bit sloppy but it's onyl temporary, should be fine(?)
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging:
This change is