Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository restructuring #562

Closed
wants to merge 19 commits into from
Closed

Repository restructuring #562

wants to merge 19 commits into from

Conversation

lockshaw
Copy link
Collaborator

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

@lockshaw
Copy link
Collaborator Author

@virena FYI

@eric-zheng
Copy link
Collaborator

Great to see this refactor of the repo structure which also cleans up old code. It's also good to see that we are going to use spdlog for logging. Just a note that from my past experience, spdlog may significantly increase the compilation time (not necessarily in ff though).

@lockshaw
Copy link
Collaborator Author

Great to see this refactor of the repo structure which also cleans up old code. It's also good to see that we are going to use spdlog for logging. Just a note that from my past experience, spdlog may significantly increase the compilation time (not necessarily in ff though).

Any reason why? We're not using the header-only version so it should only even contribute on the first build

@reyna-abhyankar
Copy link
Collaborator

reyna-abhyankar commented Feb 9, 2023

Closes #440 (element unary kernel refactor)

@lockshaw
Copy link
Collaborator Author

Moving to #622

@lockshaw lockshaw closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants